[6.x] Fix page: 0 corrupting the collection tree in ReorderEntriesController - #15429
Merged
Conversation
page: 0 (or perPage: 0) produces a negative array offset, slicing from the end of the tree, passing the out-of-date guard, and writing negative keys back onto it — corrupting the collection's tree permanently on disk.
jasonvarga
added a commit
that referenced
this pull request
Sep 10, 2026
ReorderTermsController was a copy of ReorderEntriesController as it stood on 2026-08-13. #15238 fixed the original eight days later, and the 6.x merge brought the fixed entries controller in alongside the unfixed copy. Ports that fix. A positional write replaces zip(), which padded with null and so silently dropped or duplicated branches, and a set-equality check now 409s when the submitted ids aren't a rearrangement of the page being reordered. Between them that covers short payloads, unknown slugs, duplicate ids and out-of-range pages, all of which previously returned 200 and corrupted the tree file. Also brings across #15238's toast change so the 409 message is actually shown. Adds min:1 to page and perPage, which #15238 did not have. Without it, page 0 yields a negative offset that slices from the end of the tree and then writes negative keys onto it. That hole was found here and fixed for collections in #15429. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page: 0(orperPage: 0) produces a negative array offset, which slices from the end of the tree, passes the out-of-date guard (the submitted ids genuinely match that slice), and then writes negative keys back onto the tree — appending duplicates instead of overwriting. The corrupt tree reaches disk before a 500 is thrown, permanently breaking the collection's entries listing until someone hand-edits the tree YAML.Not reachable by clicking — the CP always posts the page it fetched — but a forged/malformed request can hit it via devtools, curl, or a buggy addon, so it's worth hardening.
Adds
min:1to thepage/perPagevalidation rules, matching what already ships for taxonomy reordering.